Add filesystems docs #710
Merged
Add filesystems docs #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priteau
requested changes
Jun 23, 2025
sjpb
requested changes
Jul 24, 2025
MoteHue
force-pushed
the
filesystems-docs
branch
from
ab28a55 to
7072e7a
Compare
MoteHue
force-pushed
the
filesystems-docs
branch
from
7072e7a to
e071d01
Compare
MoteHue
force-pushed
the
filesystems-docs
branch
from
e071d01 to
d5d0a71
Compare
sjpb
requested changes
Aug 27, 2025
There was a problem hiding this comment.
LGTM, apart from a few minor suggestions re. example config paths and environment name parameterisation.
However, the file name is "filesystems" but this only covers manila, not also Lustre, or any explanation of the default NFS configuration. Are we OK with that? Do we want to at least add some sections even if lustre is "TODO"?
Co-authored-by: Steve Brasier <[email protected]>
Co-authored-by: Steve Brasier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.